search

mypaint / mypaint

MyPaint is a simple drawing and painting program that works well with Wacom-style graphics tablets.
https://mypaint.app
GNU General Public License v2.0
2.7k stars 386 forks source link

viewzoom is not handled logarithmically #816

Closed achadwick closed 7 years ago

achadwick commented 7 years ago

The docs for the new viewzoom input say:

{
            "displayed_name": "Zoom Level", 
            "hard_maximum": 4.15, 
            "hard_minimum": -2.77, 
            "id": "viewzoom", 
            "normal": 0.0, 
            "soft_maximum": 4.15, 
            "soft_minimum": -2.77, 
            "tooltip": "The current zoom level of the canvas view.  Logarithmic: 100% is 0.  200% is .69, 25% is -1.38"
        },

but freehand passes this in as the value for "scale", which is just a flat multiplier between 1/16 and 64. Please can you fix up whichever of these is in error on master ASAP?

briend commented 7 years ago

Sorry, I need to clarify that. It is in relation to the current brush's base radius. I think I had to do that to make it useable, and forgot to update the description.

achadwick commented 7 years ago

Ah, I'd never have guessed that ☺ Is the mypaint code all correct then? I'll close this when there's a PR or a commit in libmypaint for the corrected wording.

briend commented 7 years ago

Ok I updated the language to give a good brush example. I know it's a bit odd to have the zoom in "log" numbers but, well, there was a good(ish) reason for it I think. I see you merged the pull so I'll close this. Thanks!