myparcelnl / prestashop

PrestaShop module to integrate with MyParcel NL and BE
https://developer.myparcel.nl/nl/documentatie/11.prestashop.html
10 stars 5 forks source link

fix(install): fix upgrading from older versions #245

Closed EdieLemoine closed 4 months ago

EdieLemoine commented 4 months ago

INT-458

Resolves #243

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 42.81%. Comparing base (491ad5e) to head (f912465).

:exclamation: Current head f912465 differs from pull request most recent head 1f8579e. Consider uploading reports for the commit 1f8579e to get more accurate results

Files Patch % Lines
src/Service/ModuleService.php 50.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #245 +/- ## ============================================ + Coverage 41.05% 42.81% +1.75% + Complexity 622 589 -33 ============================================ Files 160 153 -7 Lines 3875 3709 -166 Branches 55 55 ============================================ - Hits 1591 1588 -3 + Misses 2229 2066 -163 Partials 55 55 ``` | [Flag](https://app.codecov.io/gh/myparcelnl/prestashop/pull/245/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl) | Coverage Δ | | |---|---|---| | [admin](https://app.codecov.io/gh/myparcelnl/prestashop/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl) | `0.00% <ø> (ø)` | | | [backend](https://app.codecov.io/gh/myparcelnl/prestashop/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl) | `68.59% <86.95%> (+4.46%)` | :arrow_up: | | [checkout](https://app.codecov.io/gh/myparcelnl/prestashop/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl) | `0.00% <ø> (ø)` | | | [frontend](https://app.codecov.io/gh/myparcelnl/prestashop/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl) | `0.00% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/myparcelnl/prestashop/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl) | `42.81% <86.95%> (+1.75%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

myparcel-bot[bot] commented 4 months ago

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit 1f8579eeec806d57520afcea5e40490fe2446869
Logs https://github.com/myparcelnl/prestashop/actions/runs/8850368096
Download https://github.com/myparcelnl/prestashop/suites/23190127334/artifacts/1451291724
EdieLemoine commented 4 months ago

@FreekVR die files kan je nooit meer hebben op een oudere versie van de module dan 4.0.0, dus het had eigenlijk geen zin om ze überhaupt te behouden. De module versies waar ze nog relevant zijn hebben ze nog wel natuurlijk