search

mysociety / SeePoliticiansTweet

0 stars 0 forks source link

Every country is Wales? #29

Closed tmtmtmtm closed 9 years ago

tmtmtmtm commented 9 years ago

screen shot 2015-08-27 at 13 24 42

zarino commented 9 years ago

That's because Wales is awesome!

zarino commented 9 years ago

If @chrismytton can make app/jobs/jekyll_site_generator_job.rb add the country name to the _config.yml it generates, then I can access it in the template using {{ site.country }} or similar.

chrismytton commented 9 years ago

This is kinda tricky because we actually want it to display the full legislature name, something like "Welsh Assembly". However we only have "Wales" as the country name and "Assembly" as the legislature name, so creating Welsh assembly is not currently possible. There was some previous discussion about this but I can't find a ticket to reference.

zarino commented 9 years ago

I remember that discussion too, but can't find the ticket in any of the everypolitician repos. It might have been in Slack instead?

Anyway, in the meantime, can't we just use the country name?

tmtmtmtm commented 9 years ago

What about just using the country name if there's only legislature for the country, and using "country name (legislature)" where there's more than one?

chrismytton commented 9 years ago

I've gone with @tmtmtmtm's suggestion and displayed the name of the legislature in brackets only if there's more than one legislature for the given countries. Pull Request here - https://github.com/mysociety/SeePoliticiansTweet/pull/55