Closed mhl closed 8 years ago
A few small comments aside this all seems to work and looks good.
I do note that if they remove some of the standard complex fields ( e.g. twitter_username ) then this crashes.
Thanks, @struan. I've created a ticket for the issue that CSV generation doesn't get its list of columns from SimplePopoloField
/ ComplexPopoloField
. As we discussed in IRC, as well, I think it's best to put off dealing with this comment until after these changes are deployed.
@mhl Is is possible to also add a votes column to the all candidates csv?
@jf1 Once the PR is closed, could you create a new ticket for that kind of request? Otherwise it's likely to be overlooked.
Apologies, will do. Done.
This PR introduces a number of improvements to CSV generation:
And an incidental improvement: