mysociety / yournextrepresentative

A website for crowd-sourcing structured election candidate data
https://candidates.democracyclub.org.uk/
GNU Affero General Public License v3.0
56 stars 21 forks source link

Improvements to CSV generation #914

Closed mhl closed 8 years ago

mhl commented 8 years ago

This PR introduces a number of improvements to CSV generation:

And an incidental improvement:

struan commented 8 years ago

A few small comments aside this all seems to work and looks good.

I do note that if they remove some of the standard complex fields ( e.g. twitter_username ) then this crashes.

mhl commented 8 years ago

Thanks, @struan. I've created a ticket for the issue that CSV generation doesn't get its list of columns from SimplePopoloField / ComplexPopoloField. As we discussed in IRC, as well, I think it's best to put off dealing with this comment until after these changes are deployed.

jf1 commented 8 years ago

@mhl Is is possible to also add a votes column to the all candidates csv?

mhl commented 8 years ago

@jf1 Once the PR is closed, could you create a new ticket for that kind of request? Otherwise it's likely to be overlooked.

jf1 commented 8 years ago

Apologies, will do. Done.