mysqljs / named-placeholders

PDO-style named to unnamed placeholders compiler
MIT License
22 stars 13 forks source link

fix: resolve dependency conflicts #37

Closed wellwelwel closed 2 months ago

wellwelwel commented 2 months ago

Sorry for the unsolicited PR. Please, feel free to close as well.

This PR follows exactly the same purpose of https://github.com/sidorares/node-mysql2/pull/2988.

Small chores

Cache

This dependency change prevents conflicts for multiple major versions of the same package for the final user.

Also, it's interesting to note that even upgrading lru-cache to the same version for both named-placeholders and mysql2, this would still imply a premature breaking change in order to an outdated version of the lru-cache (8.x instead of 11.x).

To use the latest lru-cache, it requires Node.js v20.x.x or higher.


[!NOTE] This PR doesn't depend on https://github.com/sidorares/node-mysql2/pull/2988 and vice versa. Each PR acts individually.

wellwelwel commented 2 months ago

@sidorares, to fix the release-please error:

✖ Error when creating branch
Error: release-please failed: Error creating Pull Request: Resource not accessible by integration

Go to:

Settings > Actions > General > Workflow permissions

Then, check this option 🙋🏻‍♂️

Screenshot 2024-04-26 at 01 22 45