mysteriumnetwork / node

Mysterium Network Node - official implementation of distributed VPN network (dVPN) protocol
https://mysterium.network
GNU General Public License v3.0
1.11k stars 311 forks source link

Start / stop different services from WEB-UI #1690

Closed zolia closed 4 years ago

zolia commented 4 years ago

Since introduction of NAT hole punching for WG we should be able to manage WG service through web-ui too.

Currently WG is already started on RPIs by default, but service start / stop manages only openvpn service.

We might need some layouts for this. @ignasbernotas would you be able to help with this?

anjmao commented 4 years ago

Can we make it simple to stop all services on Stop service press? What is the case to stop only once service?

zolia commented 4 years ago

It was simply not implemented. Since we don't have stop all services call it was missing from the beginning.

anjmao commented 4 years ago

Yes, my idea is just to rename it to Stop Services and stop all services instead of creating new layouts for each service etc., but if it's needed right now when ok.

iberflow commented 4 years ago

I agree with @anjmao, we should have Start Services and Stop Services and handle starting/stopping of all services in code even though we don't have that in TequilAPI and will have to do separate calls for each service. Does that sound right to you? @zolia

iberflow commented 4 years ago

I'll take this one @zolia

Waldz commented 4 years ago

How are you planning to get services to start?

According to @etherunit, problem is that users expects this button to work same way as it works after device reboots. And after reboot services are taken from this config /etc/default/mysterium/network and then not respected afterwards.

We need to migrate user's services to config.toml as it's highest priority configuration.

iberflow commented 4 years ago

Closed with https://github.com/mysteriumnetwork/dvpn-web/pull/89

Second part of the issue as stated in Waldz comment is here #2116