search

n8design / htwoo

hTWOo - a better Fluent UI framework.
http://my.n8d.at/hTWOo
MIT License
93 stars 9 forks source link

Different color on quick links #151

Closed gabbsmo closed 3 weeks ago

gabbsmo commented 3 months ago

Describe the bug While testing the different quick links styles I noticed that if you changed the top level <div> tag to <a> the text color would change in the large variante, but not for the compact ones. Since the compact variants have an explicit color set it seems like this was forgotten about for the large variants.

To Reproduce Steps to reproduce the behavior:

  1. See Compact Quick Links in Pattern Lab
  2. Change a <div> to <a> for a .hoo-qlcompact
  3. Notice text color is same
  4. See Quick Links Outline Grid in Pattern Lab
  5. Change a <div> to <a> for a .hoo-qlbtn
  6. Notice text color is changed to the regular text link color

Expected behavior Button text should have text color, not link color. Not sure about :hover.

Desktop (please complete the following information):

Additional context Entierly possible that I got this the wrong way around. Could not find a reference in Fluent UI but SharePoint is using text color at least. Also SharePoint use bold text, but that is perhaps something that is best left for applications to deside or a separate issue?

gabbsmo commented 3 months ago

Another idea, would it be possible to allow for developers to choose whether the quick link container is the <a> or a child element, for example in the case there are multiple links in one box?

StfBauer commented 4 weeks ago

The issue is a bit different. There should be a wrapping link around the items. Classname: hoo-qllink. The div on the other hand should be a <article>.

StfBauer commented 3 weeks ago

Should be fixed.