nLabs-nScope / nLab

GNU General Public License v3.0
9 stars 2 forks source link

Trigger #37

Closed michaelpeshkin closed 1 year ago

michaelpeshkin commented 1 year ago

I don't think trigger is working. On rising trigger, it sweeps continously without regard to signal. On falling trigger, it never sweeps at all.

davidjmeyer commented 1 year ago

Hmm, I'm unable to recreate this. Can you provide a screenshot, or other info that might help me reproduce?

michaelpeshkin commented 1 year ago

Works perfectly today. I will watch for it and video if I see it, probably just my mistake. I'll let you know if I figure out what my mistake was, also relevant.

ZERO complaints about download, install, fail to connect, crash – 140 students win+mac

A high priority for use in class is adjusting the baselines of CH1-4, and the trigger level (and preferably the trigger tab color), using tabs on the scope face.

Does this reply get back to you David?

From: David Meyer @.> Date: Tuesday, October 17, 2023 at 11:05 PM To: nLabs-nScope/nScope @.> Cc: michaelpeshkin @.>, Author @.> Subject: Re: [nLabs-nScope/nScope] Trigger (Issue #37)

Hmm, I'm unable to recreate this. Can you provide a screenshot, or other info that might help me reproduce?

— Reply to this email directly, view it on GitHubhttps://github.com/nLabs-nScope/nScope/issues/37#issuecomment-1767602659, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BCWWB7JAXQO4OT7JVOXVXXLX75IQ3AVCNFSM6AAAAAA57OVDFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRXGYYDENRVHE. You are receiving this because you authored the thread.Message ID: @.***>

davidjmeyer commented 1 year ago

Yep, the email seems to be attached to the issue.

The level shifting and tab dragging was just completed in https://github.com/nLabs-nScope/nScope/pull/35

I'll be pushing out an update before the end of the week.