kamalnadjieb
commented
4 years ago Hi Leon,
Sorry but I have created the test already with Github Workflows. Maybe next time you can submit another PR. Thanks!
Closed leonitousconforti closed 4 years ago
kamalnadjieb
commented
4 years ago Hi Leon,
Sorry but I have created the test already with Github Workflows. Maybe next time you can submit another PR. Thanks!
These are some tests wrote to test the functionality of the streamer. It uses libcurl to download the image and verify that the image is exactly the same as it was when it was uploaded by the streamer. In order to verify that it was the exact same image, the image could not be encoded as a jpeg (even with the quality set to 100%, jpeg still loses some information although not noticeably when looking at the images side by side). Therefore, the tests encode the image as a .png, as png is lossless, and thus the image can be verified as an exact copy. No changes had to be made to the streamer to get it to work with the .png encoding in the tests, it just worked.
On a side not, I was not able to get your CMake config working on my machine, probably something wrong with my environment. So the CMake file for the tests is a little different than the ones already in the repo, change it up if you can get it working your way but I couldn't.