search

naemon / naemon-livestatus

Naemon - Livestatus Eventbroker Module
GNU General Public License v2.0
26 stars 30 forks source link

fix-el8-crash #73

Closed pbiering closed 4 years ago

pbiering commented 4 years ago

split-out to dedicated patch only

pbiering commented 4 years ago

this superseeds https://github.com/naemon/naemon-livestatus/pull/72

and fixes https://github.com/naemon/naemon-livestatus/issues/70

jacobbaungard commented 4 years ago

Hi @pbiering,

Starting to work through these (slowly). Thanks again for sending in the patches.

For this one, I can replicate the exact issue when installing from the repos, but for some reason, not when I am compiling the 1.2.0 release from source myself. Did you manage to replicate the issue when building from source, too?

Wonder if there are some gcc/glibc changes which are triggering this issues.

jacobbaungard commented 4 years ago

Merged here: https://github.com/naemon/naemon-livestatus/commit/341eccc1ccfbf8bf31a1c2092f16ed2d573369b9

Thanks for the PR, I will try to get around to the rest tomorrow!

pbiering commented 4 years ago

For this one, I can replicate the exact issue when installing from the repos, but for some reason, not when I am compiling the 1.2.0 release from source myself. Did you manage to replicate the issue when building from source, too?

Haven' tested because target is stability on EL8

Wonder if there are some gcc/glibc changes which are triggering this issues.

as also compiled with "clang" has not bring up the issue I assume either huge code optimization or additional security mechanism inserted during compilation with gcc

jacobbaungard commented 4 years ago

I tested the new daily build (https://build.opensuse.org/package/binaries/home:naemon:daily/naemon-livestatus/CentOS_8_Stream) and it seems to work fine, so that's great news. Thanks again for the PR!