search

naeramarth7 / clean-greader

clean-greader is a tiny tiny rss theme based on the latest Google Reader and inspired by other Google Services.
128 stars 22 forks source link

Ui fixes #19

Closed wbagdon closed 7 years ago

wbagdon commented 7 years ago

Fixes #18

@naeramarth7, not sure why the FontAwesome icons are not overlaying on the "Special" feeds... Any ideas?

wbagdon commented 7 years ago

Realizing now that I've "fixed" this but not in the correct way, I've just disabled the hiding of all the icons by breaking the selector.

naeramarth7 commented 7 years ago

@wbagdon Seems like tt-rss changed the structure. The img nodes do not have any siblings anymore. This makes it impossible to use font-awesome here since img nodes do not support pseudo selectors.

I updated your PR hiding the original icons and displaying our custom icons instead via the background-image attribute instead. Now, they won't scale anymore, since they're base64 encoded pngs, though 32px resolution should be sufficient for the 16px icons.

Can you confirm this is working again?

screen shot 2017-08-05 at 13 17 33

... and thanks a lot for pointing out the issue in the first place! (:

wbagdon commented 7 years ago

Works great!! Thanks