search

naeramarth7 / clean-greader

clean-greader is a tiny tiny rss theme based on the latest Google Reader and inspired by other Google Services.
128 stars 22 forks source link

Toolbar style broken since tt-rss v1.12 #3

Closed HaraldDerEine closed 10 years ago

HaraldDerEine commented 10 years ago

The style of the toolbar is broken after the upgrade to tt-rss v1.12 on my synology. bildschirmfoto 2014-03-28 um 15 28 14

hurik commented 10 years ago

maharifu fixed it in his fork: https://github.com/maharifu/clean-greader

which isn't working ...

HaraldDerEine commented 10 years ago

I see ... looks a bit better, but still broken :(

naeramarth7 commented 10 years ago

There seems to be a new layout in 1.12 - had to re-position the some containers and include the new .holder > .main containers for the toolbar links. Should be working fine now - sorry for the delay.

HaraldDerEine commented 10 years ago

Very nice! The toolbar is now fine again. But now the Headline of an article is moved to far when scrolling down ... I hope the scrrenshot describes the problem better than my words. bildschirmfoto 2014-04-04 um 11 56 51

BTW: No need to apologize for anything. I'm very happy and grateful for your theme and all the work you put in. Many, many thanks for that!

hurik commented 10 years ago

Thanks, working nice now!

@HaraldDerEine: that's a feature of the new version. when you use the normal style. open an article and scroll down the headline moves too.

@naeramarth7: quick question: how do I change the wide of the left sidebar?

naeramarth7 commented 10 years ago

@hurik Take a look at the css/modules/_dimensions.scss. $card-nav-width: 320px; = width of the left bar $max-content-width: 700px; = max-width for articles

Change it to your needs and run a gulp sass. Guess those need to be moved to the config file, though.

HaraldDerEine commented 10 years ago

@hurik I can't reproduce the behavior you describe. When I scroll down with default.css active, the headline sticks to the top of the page. bildschirmfoto 2014-04-04 um 12 56 51

naeramarth7 commented 10 years ago

@HaraldDerEine When you scroll down, the title bar is replaced by a new, floating one (you can actually see the first icon in the title bar changing). The feature is not that new, but the layout got changed, so there was a misbehavior after the first fix - just forgot the floating title bar...
Fixed for this theme in e8dfc6f0c0b98baf630f41f64b99ac6605c60ae1 .

HaraldDerEine commented 10 years ago

Yes. Now it's perfect! Again, thanks alot!

naeramarth7 commented 10 years ago

@HaraldDerEine You're welcome (: