Build failure

[GoogleCodeExporter]

Hi Nick again,

The latest release fails to build on some of our boxes:

cc1: warnings being treated as errors
test/modp_numtoa_test.c: In function 'testDTOANonFinite':
test/modp_numtoa_test.c:338: error: unused variable 'buf1'

The following trivial patch fixes the problem:

diff --git a/3rdparty/modp/test/modp_numtoa_test.c
b/3rdparty/modp/test/modp_numtoa_test.c
--- a/3rdparty/modp/test/modp_numtoa_test.c
+++ b/3rdparty/modp/test/modp_numtoa_test.c
@@ -336,6 +336,7 @@
 // Test NaN and Infinity behavior
 static char* testDTOANonFinite() {
     char buf1[100];
+    (void)buf1;
     char buf2[100];
     double d;

For the record this happens with Debian Lenny. Apparently it doesn't define
INFINITY macro so the code where buf1 is used doesn't get to compile and
thus we get unused variable warning.

Original issue reported on code.google.com by ilya.m...@gmail.com on 25 Mar 2010 at 4:16

[GoogleCodeExporter]

argh, yeah.

Sorry about that.

I committed the change.  Do you need a new release?

--nickg

Original comment by nickgsup...@gmail.com on 26 Mar 2010 at 4:33

[GoogleCodeExporter]

Up to you, Nick. We have a patched copy of the project in our repostory so 
releases
do not matter much to us.

Original comment by ilya.m...@gmail.com on 29 Mar 2010 at 7:32

[GoogleCodeExporter]

fixed long ago.

Original comment by nickg@client9.com on 26 Feb 2012 at 4:22

• Changed state: Verified