search

nalexn / clean-architecture-swiftui

SwiftUI sample app using Clean Architecture. Examples of working with CoreData persistence, networking, dependency injection, unit testing, and more.
MIT License
5.56k stars 671 forks source link

fix: simplify self and add final keyword to class #100

Open quokkaKyu opened 1 week ago

quokkaKyu commented 1 week ago

Hello, I found out that the entityName variable in the ManagedEntity protocol points to itself. This may be a difference in taste. But how about fixing it like this?

quokkaKyu commented 6 days ago

Hello, I have some additional recommendations. How about adding the final keyword to classes that do not inherit?