search

nalgeon / redka

Redis re-implemented with SQLite
BSD 3-Clause "New" or "Revised" License
3.53k stars 101 forks source link

Add basic `EVAL` command #39

Closed smitssjors closed 1 week ago

smitssjors commented 1 month ago

This is an initial implementation of the EVAL command from redis. It is currently very barebones and only the redis.call function is available.

I want to open this PR to get some feedback as I am a Go noob so if there are any suggestions you are welcome to give feedback.

nalgeon commented 1 month ago

I'm sorry that you spent time implementing eval, but it is not planned for 1.0. It is always better to open an issue first, as the readme says:

For anything other than bugfixes, please first open an issue to discuss what you want to change.

And in the case of Lua scripting, there is already a closed issue #21.

smitssjors commented 1 month ago

Hey no problem.

I saw the issue and I understand that you would like more adoption before you implement Lua scripting. However, most web apps need job processing and almost all queueing frameworks require Lua scripting. Thus not having it would prevent all these projects from adopting redka, which would in-turn slow demand for the feature.

This is my opinion on the matter but it is your project so I ultimatly respect your decision.

I'll just iron out some of the bugs in what I have as an excerice and you are free to do with it however you like.