search

namazso / OpenHashTab

📝 File hashing and checking shell extension
GNU General Public License v3.0
3.12k stars 119 forks source link

Remove `v` prefix in CI_VERSION #188

Closed sitiom closed 1 year ago

sitiom commented 1 year ago

DisplayVersion should not contain the v prefix. See https://github.com/namazso/OpenHashTab/issues/82#issuecomment-922915691

namazso commented 1 year ago

I'm pretty sure the linked issue was an issue in winget metadata. Windows apps have both numeric and string versions, and the numeric ones do not contain the v. It was also fixed on winget side since:

image

Is there any point to this change that I fail to notice?

sitiom commented 1 year ago

I'm pretty sure the linked issue was an issue in winget metadata. Windows apps have both numeric and string versions, and the numeric ones do not contain the v. It was also fixed on winget side since:

image

Is there any point to this change that I fail to notice?

It's unusual for a package to include the v prefix in the PackageVersion, and is usually trimmed away and matches the DisplayVersion in the installed apps section:

image

However, the DisplayVersion here also doesn't trim the v prefix as well (which is also not usual). This change fixes it, much like with the 2.x versions:

image

namazso commented 1 year ago

Hm.. Will this not break the currently working winget stuff either? I guess not because the previous issue was with 2.x overriding v3.x so it will just accidentally work. Unless winget code was changed to accomodate the v

I also plan to switch to WiX 4 and MSIX for distribution (hence the deprecation notice for <1909) so stuff might change over installation version mess too.

sitiom commented 1 year ago

Hm.. Will this not break the currently working winget stuff either? I guess not because the previous issue was with 2.x overriding v3.x so it will just accidentally work.

Yeah, I guess that would be the case. The previous 2.x versions can then be brought back in Winget (for completeness if someone likes to)