namecoin / nmcontrol

Namecoin Control. This repo is deprecated in favor of https://github.com/namecoin/ncdns
136 stars 38 forks source link

Installer instructed not to start service at startup, but does the opposite #99

Open unsystemizer opened 9 years ago

unsystemizer commented 9 years ago

v0.8:

When installing I chose not to install NMControl as service, but it still tried to start:

2015-09-03 14:33:58,776 - nmcontrol - INFO - ###################################################################################
2015-09-03 14:33:59,065 - nmcontrol - INFO - Daemon mode not possible on MS Windows.

I looked at service-dns.conf and I have this:

[dns]
; Launch at startup
; start=1

Does ; mean this is the default? It seems the installer always sets this to 1, or doesn't specifically set start=0 even when instructed.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

phelixbtc commented 9 years ago

This is independent from the conf file you mention. Nonetheless it is not supposed to do this...

phelixbtc commented 9 years ago

Could it be the reason was that you ran the installer before with autostart activated? You then ran it a second time with autostart disabled and it did not get removed. I have it fixed by cleaning up any previous autostart links in https://github.com/namecoin/nmcontrol/pull/100

unsystemizer commented 9 years ago

I don't think I did (I have Namecoin Core and NameGUI, don't think I had tried NMControl before).

Regardless of autostart links, shouldn't the config file setting matter? (What I mean by this is, if autostart link starts NMControl, NMControl should check the config file and if it says start=0, it should exit)

phelixbtc commented 9 years ago

The start settings in the conf files are only relevant for the specific plugins, not for NMControl as a whole.

phelixbtc commented 9 years ago

About to close...