Implement TCP Unicast Face Logic - Githubissues

named-data / YaNFD

Yet another Named Data Networking Forwarding Daemon

https://pkg.go.dev/github.com/named-data/YaNFD

MIT License

12 stars 10 forks source link

Implement TCP Unicast Face Logic #10

Closed yashlala closed 3 years ago

yashlala commented 3 years ago

PR Copied from https://github.com/eric135/YaNFD/pull/1.

Changes:

In ndn/uri.go, GetURIType() would return type uriType, which wasn't visible outside the module. To make this method functional, the uriType has been renamed to URIType.
Added Unicast TCP face to face/unicast-tcp-transport.go.
Added associated TCP logic in ndn/uri.go.

Potentially Harmful Decisions:

TCP is connection based, so connections can be explicitly closed (unlike UDP). This raises the question of whether to give each interface an expirationTime for TCP Unicast. I've opted to add an expiration time, with a default value of one hour. This mirrors the current settings for UDP, but not Ethernet.