search

namshi / roger

A continuous integration and build server for Docker containers
127 stars 26 forks source link

remove spaces in urlParts #37

Closed razanbilwani closed 7 years ago

razanbilwani commented 7 years ago

@shidhincr Or, I could add trim, wdyt?

shidhincr commented 7 years ago

@razanbilwani Good to use trim

shidhincr commented 7 years ago

@razanbilwani Better to do like this

In https://github.com/namshi/roger/blob/master/src/client/components/projectDetails.jsx#L33

let [repo, branch] = ( path || '' ).split(':').map(item => item.trim());
razanbilwani commented 7 years ago

@shidhincr cool, did it in #38