search

nanograv / PINT

PINT is not TEMPO3 -- Software for high-precision pulsar timing
Other
121 stars 101 forks source link

Time derivatives of NE_SW (NE_SW1, ...) #1859

Open abhisrkckl opened 1 week ago

abhisrkckl commented 1 week ago

Complements #1854

dlakaplan commented 1 week ago

Maybe clarify that you are putting in time derivatives here (and not partial derivatives needed for fitting)?

kerrm commented 1 week ago

Two quick comments: (1) perhaps add a short circuit for non time dependent cases to avoid any performance regression (2) the test case should include a test of the correctness, e.g. that NE_SW1 = 1 produces a value of 5 a year 0 and 10 at year 5

abhisrkckl commented 3 days ago

Two quick comments: (1) perhaps add a short circuit for non time dependent cases to avoid any performance regression (2) the test case should include a test of the correctness, e.g. that NE_SW1 = 1 produces a value of 5 a year 0 and 10 at year 5

Added both.