search

nanophotonics / nplab

Core functions and instrument scripts for the Nanophotonics lab experimental scripts
GNU General Public License v3.0
38 stars 15 forks source link

Issue120 #138

Closed YagoDel closed 3 years ago

YagoDel commented 3 years ago

Adds the functionality that MessageBusInstrument can automatically handle echo-ing instruments, fixes #120

I did a bunch of PEP8 cleanup, so if you want to see the important changes, look at 21cc1239c1dbd547b91ff22bc8f24058308319e2

YagoDel commented 3 years ago

I agree with the readline vs read thing (I recently tried swapping a VisaInstrument into a SerialInstrument and that was mildly annoying). I guess when fixing that is when we would also think about refactoring into _readline. Maybe make another issue?