napalm-automation / napalm-ios

Apache License 2.0
31 stars 40 forks source link

Add support to napalm-ios for netmiko telnet type #132

Closed sorano closed 6 years ago

sorano commented 7 years ago

Description of Issue/Question

Feature request: Add support to napalm-ios to force and/or failover to netmiko telnet type.

netmiko supports telnet with the telnet device type: device['device_type'] = 'cisco_ios_telnet'

https://github.com/ktbyers/netmiko/issues/159#issuecomment-245977602

ktbyers commented 7 years ago

@dbarrosop @mirceaulinic What are your thoughts on adding an optional_argument ios_transport which defaults to SSH (but also supports telnet).

I would then force the transfer mode to inline (as it would have to use the inline-transfer that uses TCL).

dbarrosop commented 7 years ago

What are your thoughts on adding an optional_argument ios_transport which defaults to SSH (but also supports telnet).

+100

But call it just transport, I don't think it's ios specific and if we build a generic napalm-netmiko it might end up supporting that same optional_arg

mirceaulinic commented 7 years ago

Yes, i would suggest the same - i think transport would make more sense and could be used by few other drivers.

mirceaulinic commented 7 years ago

Hi @sorano - would you be able to submit a pull request with the changes required for this? Netmiko seems to have good support for telnet so I assume it's pretty easy. Thanks!

mirceaulinic commented 6 years ago

Hi @sorano - I believe this has been already implemented.

We are currently in the process of reunification, please check https://napalm-automation.net/reunification/. Going forward, we'd like to ask you to submit Pull Requests and Issues to the main repository: https://github.com/napalm-automation/napalm.