search

napalm-automation / napalm-ios

Apache License 2.0
31 stars 40 forks source link

Modifications to get_optics to survive from N/A output power value #136

Closed kaage closed 7 years ago

kaage commented 7 years ago

Part of: https://github.com/napalm-automation/napalm-base/issues/237

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 67.33% when pulling d0f4af59bd3d212d1cd59db1f648eebe63f16901 on kaage:develop into 1069480b7b1054d2070fba8b32b11a01c4fa333c on napalm-automation:develop.

ktbyers commented 7 years ago

This looks good to me...so can integrate once we decide default power value for "N/A".

dbarrosop commented 7 years ago

FYI

I have created an Epic:

https://github.com/napalm-automation/napalm-base#boards?epics=53213638_237&repos=76636028,67531943,32737992,49192168,76226659,53213638,70275626,74009031,79204958,53214857,53658916,54102492,53492012,53583872,64762070,53258608,54017316,58233121,53928100,61367331,56185510,74008814,57410375,69223886,68358654,69226025,67635081

ktbyers commented 7 years ago

@kaage Can you update this to make the "infinite" value be -100?

ktbyers commented 7 years ago

I will integrate and fix the -100 references.