Closed mirceaulinic closed 7 years ago
@ktbyers is this something we may want under this driver, or do you think we should move it more rather under netmiko though? I thought that we can add this optional arg also under panos & others that use SSH and implicitly netmiko - let me know if that would make sense.
@mirceaulinic Yeah, it is probably more logical under Netmiko, let me look at it a bit more.
@ktbyers I submitted a pull request to Nemiko for this: https://github.com/ktbyers/netmiko/pull/476. If that's sane, I'll adjust this PR so napalm-ios will use the new argument.
@mirceaulinic That PR has been included in Netmiko.
Thanks for reminder @ktbyers - I will adapt the code after Netmiko is released, otherwise I think the tests will fail.
Waiting on Netmiko release.
@mirceaulinic Netmiko has been released with support for Paramiko Keepalive.
Do we still need this PR any more? I assume we will just close this and keep the is_alive PR?
Yes, we still need this PR, I will update it shortly. The keepalive is independent of the NULL byte: it's used to survive firewall purges even when is_alive
is not called.
For example, under napalm-junos we have keepalive, but we won't be sending any equivalent of the NULL byte (otherwise NETCONF will close the connection),
@ktbyers I have updated this PR and we'll be using Netmiko's keepalive arg directly - sorry for late reply here.
Under https://github.com/napalm-automation/napalm-junos/pull/147 an user has added the keepalive optional argument. We have then thought that it would be good to leverage this option for other SSH-based drivers. Opening this PR to add the new keepalive optional arg.