Closed mirceaulinic closed 7 years ago
@ktbyers do you think we can merge this PR then release a new version somewhere next week?
@mirceaulinic I will try to review this today and tomorrow. I am going to be out traveling a lot next week so I will try to get the PR integrated. Might be difficult for me to do a release. Happy for you to do one, however.
@mirceaulinic I asked this in the slack channel also? Why are we wrapping is_alive
in a dictionary as opposed to just returning a boolean?
return {
'is_alive': False
}
Never mind I see it in napalm-junos that way.
As discussed with David B. under https://github.com/napalm-automation/napalm-base/pull/249, although it may be ambiguous that this method also executes an action, it's safer to determine the real status of the connection.
The paramiko flag is unreliable and it can return True even if the connection is actually unusable.