search

napalm-automation / napalm-ios

Apache License 2.0
31 stars 40 forks source link

update get_interfaces #157

Closed itdependsnetworks closed 7 years ago

itdependsnetworks commented 7 years ago
Alternate to https://github.com/napalm-automation/napalm-ios/pull/151, pulled some code from @kbirkeland . Not yet ready to push, but wanted to put the PR in before I forgot :)
coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 70.295% when pulling f7486e0c4143b23413b5fe4f377f79a0dec4044f on itdependsnetworks:get_interfaces into 6c8504602de0c82bd0d496cd65034b15d272f322 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 70.295% when pulling f7486e0c4143b23413b5fe4f377f79a0dec4044f on itdependsnetworks:get_interfaces into 6c8504602de0c82bd0d496cd65034b15d272f322 on napalm-automation:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 70.295% when pulling f7486e0c4143b23413b5fe4f377f79a0dec4044f on itdependsnetworks:get_interfaces into 6c8504602de0c82bd0d496cd65034b15d272f322 on napalm-automation:develop.

mirceaulinic commented 7 years ago

Oh my, you weren't kidding when you said you want to improve the stats by adding lots of mock data. BTW: we count the number of PRs, not the lines added. :]

itdependsnetworks commented 7 years ago

lol, just happen to work out that way. Been meaning to put in issue to clean up multiple show int calls, and the mac one and had seen the issue already opened. Had demo data from ntc-show and figured there was a reason we used both, so included them both :)

dbarrosop commented 7 years ago

Hahaha! keep them coming!