Closed dalthviz closed 1 year ago
No. Plugin uses setuptools_scm to determine version. And setuptools_scm both generate _version.py and update plugin metadata.
Maybe I experienced this because I didn't use the use_git_tags_for_versioning
option which caused the plugin to not get the related setuptools_scm
stuff?
Just double checking, but if the change explained in the OP is not necessary feel free to close this :+1:
Ok. You are correct. I miss this variant. I think that it should be fixed.
Hi, doing an initial release for a plugin, that used the cookiecutter to generate its initial structure, I noticed that the
setup.cfg
version doesn't use the__version__
value available at__init__.py
. I fixed that on the plugin by changing:https://github.com/napari/cookiecutter-napari-plugin/blob/d0c893f586c6c041d1d362eedfa7b85f6613a900/%7B%7Bcookiecutter.plugin_name%7D%7D/setup.cfg#L4
To
Which as a template I think it should be something like:
Is that the correct approach and a fix to do here?