Bugfix: move endif and reader-if so all widgets work if only widgets are give `y`

napari / cookiecutter-napari-plugin

Cookiecutter for napari plugins

BSD 3-Clause "New" or "Revised" License

67 stars 39 forks source link

Bugfix: move endif and reader-if so all widgets work if only widgets are give `y` #173

Closed psobolewskiPhD closed 6 months ago

psobolewskiPhD commented 6 months ago

Closes: #172

In https://github.com/napari/cookiecutter-napari-plugin/pull/168 when widgets got an update a logic error was introduced into napari.yaml. This shifts the endif and if to the proper line (after all of the widgets).

I tested locally and could reproduce the issue and this fixes it. I wonder if we should try to extend the make and install test to try each of the plugin types individually?

jni commented 6 months ago

I wonder if we should try to extend the make and install test to try each of the plugin types individually?

I don't know anything about how the cookiecutter is tested but I will merge this quickly and we can worry about testing elsewhere, since this will immediately improve the situation for any users. Thank you for the quick fix @psobolewskiPhD!