search

napari / napari-animation

A napari plugin for making animations
https://napari.github.io/napari-animation/
Other
79 stars 27 forks source link

Fix for 0.5.2+ #232

Closed Czaki closed 2 months ago

Czaki commented 2 months ago

This PR is pointing place where animation code depends on events order.

After this fix, the code will, work with 0.5.2 but not earlier.

Closes #231

The alternative is to use `position='first`` when connecting event. But code that do not depend on callback order may be better.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.24%. Comparing base (ba8ab53) to head (e058377). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #232 +/- ## ======================================= Coverage 86.24% 86.24% ======================================= Files 26 26 Lines 1076 1076 ======================================= Hits 928 928 Misses 148 148 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

psobolewskiPhD commented 2 months ago

I don't like restricting napari version... I tried adding the position kwarg in those connect in the __init__ but that didn't work. Here's what I came up with: https://github.com/napari/napari-animation/pull/233

It's breaking in that it removes the insert kwarg for updating in-place that was triggering the bug.