napvideo improvements - Githubissues

TimGroeneboom commented 2 months ago

This PR aims to fix a problem where video looping and seeking would not be consistent. The seek operation was discarding the seek frames, resulting in those frames to be skipped altogether and also causing synchronization issues when playing two seperate videos that need to be in sync
Added a bool arg for video play giving the user the option to not clear the previous textures. This prevents black or green textures from being rendered when calling play or switching videos

To test : Build and run videomodulation demo, observe the perfectly looping video

cklosters commented 2 months ago

Thanks for the PR, I'll have time to properly review it beginning of next month.

cklosters commented 2 months ago

Looking good, for some reason the videomodulation demo doesn't want to close when running the package validation script on the PI4B, but otherwise starts / stops fine, will update the agent and try again. Also cleaned up package allocation - the io thead boolean wasn't used.

cklosters commented 1 month ago

It passes all the checks, thread safety is now guaranteed, good to go in.

napframework / nap

napvideo improvements #28