Open skliper opened 10 months ago
Checklist (Please check before submitting)
Is your feature request related to a problem? Please describe. Split off from #99 to better focus bug fix vs higher level design concepts.
There's local dfns of SC owned elements, which is a maintenance issue. https://github.com/nasa/LC/blob/ca4767089966c6ba5b308fa42272763a6881c192/config/default_lc_interface_cfg.h#L40-L60 https://github.com/nasa/LC/blob/ca4767089966c6ba5b308fa42272763a6881c192/config/default_lc_interface_cfg.h#L62-L78 https://github.com/nasa/LC/blob/ca4767089966c6ba5b308fa42272763a6881c192/config/default_lc_msgstruct.h#L228-L254
Describe the solution you'd like LC depends on SC as designed, recommend single source of truth.
Describe alternatives you've considered None
Additional context Review functional testing to confirm this dependency is sufficiently tested.
Requester Info Jacob Hageman - NASA/GSFC
Definitely agree, LC should not be redefining these structs, it should be using the definitions from SC if it needs them.
Checklist (Please check before submitting)
Is your feature request related to a problem? Please describe. Split off from #99 to better focus bug fix vs higher level design concepts.
There's local dfns of SC owned elements, which is a maintenance issue. https://github.com/nasa/LC/blob/ca4767089966c6ba5b308fa42272763a6881c192/config/default_lc_interface_cfg.h#L40-L60 https://github.com/nasa/LC/blob/ca4767089966c6ba5b308fa42272763a6881c192/config/default_lc_interface_cfg.h#L62-L78 https://github.com/nasa/LC/blob/ca4767089966c6ba5b308fa42272763a6881c192/config/default_lc_msgstruct.h#L228-L254
Describe the solution you'd like LC depends on SC as designed, recommend single source of truth.
Describe alternatives you've considered None
Additional context Review functional testing to confirm this dependency is sufficiently tested.
Requester Info Jacob Hageman - NASA/GSFC