[x] I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.
Describe the contribution
Fixes #14
LC_SampleAPs() has been refactored to remove the extraneous if statement.
Action points are still sampled in the same way, and if StartIndex == EndIndex, the for loop will only run once (i.e. the same as before).
Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
Intent of the code remains basically unchanged, although the logic has changed slightly.
Main change is that CurrentAPState is checked as valid before any sampling of action points, whereas previously this was only checked in the single action point sample condition - i.e. if (StartIndex == EndIndex)
Checklist
Describe the contribution
LC_SampleAPs()has been refactored to remove the extraneousifstatement.StartIndex == EndIndex, theforloop will only run once (i.e. the same as before).Testing performed GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes Intent of the code remains basically unchanged, although the logic has changed slightly. Main change is that
CurrentAPStateis checked as valid before any sampling of action points, whereas previously this was only checked in the single action point sample condition - i.e.if (StartIndex == EndIndex)Contributor Info Avi @thnkslprpt