Remove remaining stray references to old event types

[thnkslprpt]

Checklist

• [x] I reviewed the Contributing Guide.
• [x] I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug While updating event type constants in https://github.com/nasa/cFE/pull/2221 it was noticed that a few stray uses of the old types (CFE_EVS_ERROR, CFE_EVS_INFORMATION etc.) were still present in LC's commented-out tests.

Expected behavior Update to new event type constants or remove these commented-out tests.

Code snips https://github.com/nasa/LC/blob/358fc484e93d0c2c63e4a2faf1d61883962f0c0b/unit-test/lc_app_tests.c#L470 https://github.com/nasa/LC/blob/358fc484e93d0c2c63e4a2faf1d61883962f0c0b/unit-test/lc_app_tests.c#L283

Reporter Info Avi Weiss @thnkslprpt