LC_SbInit casts every Status to unsigned int in every event message

nasa / LC

The Core Flight System (cFS) Limit Checker (LC) application.

Apache License 2.0

30 stars 21 forks source link

LC_SbInit casts every Status to unsigned int in every event message #9

Closed skliper closed 2 years ago

skliper commented 2 years ago

LC_SbInit is casting the Status in every event send to an unsigned int. The cast appears unnecessary, CFE_EVS_SendEvent takes a variable length of arguments because it does a formatting of the string with the values sent AND the format in the send events is %08X (print 8 characters in upper case hex).

Imported from GSFCCFS-1099

skliper commented 2 years ago

The cast is necessary since Status is of type int32, and the print format expects unsigned int. Note the preferred solution for consistent cFE status reporting is to use CFE_ES_StatusToString added in nasa/cFE#2113.