Closed thomas-bc closed 1 year ago
Some minor change requests, otherwise this refactor looks really nice!
Two other comments:
pip install
without -e
to make sure the templates installed correctly. -e
with no issueI addressed your comments, ready for re-review
fprime-util new
Change Description
new --deployment
utility_entry()
to cli.py because it was odd in _buildhelper.pyutility_entry()
calls only if it needs tonew
target to generate is now an argparse _mutually_exclusivegroup so we can defer that logic to argparse instead of handling itRationale
Addresses https://github.com/nasa/fprime/issues/1926. Will be used for short tutorials and workshops. Has been requested for a long time. The created deployment contains the basic CNDH stack so that users can get started easily.
Request for comments
The cookiecutter stuff is in
fbuild/interaction.py
which is a little odd hierarchy/naming. I was thinking of putting thenew_***
functions in a new module underutil/
but that would make yet more refactoring. Let me know if you think that's good or if you see issues with that and I'll put it in for the futurenew --project
feature.Future Work
TODO: loadParameter() has been commented out in the generated
configureTopology()
because the function is not autocoded yet. A fix will likely be made where the function gets autocoded even if not parameters are used. Should be un-commented then.We could add the following cookiecutter options: