search

nasa / fprime-tools

F´ Python tooling and helpers.
https://github.com/nasa/fprime
Apache License 2.0
20 stars 38 forks source link

Add version check command #190

Closed 0x48piraj closed 8 months ago

0x48piraj commented 8 months ago
Related Issue(s) https://github.com/nasa/fprime/issues/2407
Has Unit Tests (y/n) n
Documentation Included (y/n) y

Change Description

Adds a version check command for

Rationale

Help debug things

Future Work

Unit tests preferably.

0x48piraj commented 8 months ago

I also added a skeleton unit test for commands (as asked above in the PR), it's pretty empty as of now but I would be happy to write tests for special-parser commands.

thomas-bc commented 8 months ago

Looks like you also need to run the formatter -

pip install black
black ./path/to/file_to_format.py

I figured you might want to take this across the finish line yourself, but let me know if you want me to help make some changes.

0x48piraj commented 8 months ago

All the requested changes were made including the unused import one and it works as intended in local settings.

thomas-bc commented 8 months ago

Thanks! Note to myself: add OS and processor architecture information as well

0x48piraj commented 8 months ago

Rather than using sys, I utilized the platform library for retrieving all system info.

0x48piraj commented 8 months ago

Any updates on this @thomas-bc?

thomas-bc commented 8 months ago

Apologies for the delay, I was out for a bit. LGTM! Thank you very much for this, we want to add this command to our bug_report.md issue template over on https://github.com/nasa/fprime. Feel free to make the PR yourself there if you want to! e.g. add a section/checkmark

[] Please paste the output of fprime-util version-check: