nasa / fprime-tools

F´ Python tooling and helpers.
https://github.com/nasa/fprime
Apache License 2.0
20 stars 38 forks source link

Swap `regCommands()` and `configTopology` + Move Buffmgr and Framing setup to front #208

Closed Lex-ari closed 2 months ago

Lex-ari commented 2 months ago
Related Issue(s) nasa/fprime#2791
Has Unit Tests (y/n) n
Documentation Included (y/n) n

Change Description

Swap regCommands() and configureTopology() in Topology.cpp Move BufferManager Setup and Framing/Deframing setup to front in configureTopology() in Topology.cpp

Rationale

Testing/Review Recommendations

CI to ensure standard projects are working correctly

CC: @timcanham @LeStarch @bocchino @Joshua-Anderson

timcanham commented 2 months ago

LGTM to me too. Order shouldn't matter.

LeStarch commented 2 months ago

@Lex-ari: we need to also change the bootstrap templates.