nasa / openmct

A web based mission control framework.
https://nasa.github.io/openmct/
Other
12.09k stars 1.26k forks source link

[Telemetry API] Prevent Subscriptions with different options from overwriting each other #7930

Open jvigliotta opened 2 weeks ago

jvigliotta commented 2 weeks ago

Closes #7933

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.24%. Comparing base (ea9947c) to head (6569c75).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #7930 +/- ## ========================================== - Coverage 57.66% 57.24% -0.42% ========================================== Files 677 677 Lines 27373 27404 +31 Branches 2689 2689 ========================================== - Hits 15784 15688 -96 - Misses 11250 11375 +125 - Partials 339 341 +2 ``` | [Flag](https://app.codecov.io/gh/nasa/openmct/pull/7930/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa) | Coverage Δ | | |---|---|---| | [e2e-ci](https://app.codecov.io/gh/nasa/openmct/pull/7930/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa) | `62.63% <100.00%> (+0.15%)` | :arrow_up: | | [e2e-full](https://app.codecov.io/gh/nasa/openmct/pull/7930/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa) | `23.59% <5.26%> (-34.55%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/nasa/openmct/pull/7930/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa) | `49.34% <65.78%> (-0.02%)` | :arrow_down: | | [Files with missing lines](https://app.codecov.io/gh/nasa/openmct/pull/7930?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa) | Coverage Δ | | |---|---|---| | [example/generator/GeneratorMetadataProvider.js](https://app.codecov.io/gh/nasa/openmct/pull/7930?src=pr&el=tree&filepath=example%2Fgenerator%2FGeneratorMetadataProvider.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa#diff-ZXhhbXBsZS9nZW5lcmF0b3IvR2VuZXJhdG9yTWV0YWRhdGFQcm92aWRlci5qcw==) | `100.00% <ø> (ø)` | | | [example/generator/StateGeneratorProvider.js](https://app.codecov.io/gh/nasa/openmct/pull/7930?src=pr&el=tree&filepath=example%2Fgenerator%2FStateGeneratorProvider.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa#diff-ZXhhbXBsZS9nZW5lcmF0b3IvU3RhdGVHZW5lcmF0b3JQcm92aWRlci5qcw==) | `100.00% <100.00%> (ø)` | | | [src/api/telemetry/TelemetryAPI.js](https://app.codecov.io/gh/nasa/openmct/pull/7930?src=pr&el=tree&filepath=src%2Fapi%2Ftelemetry%2FTelemetryAPI.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa#diff-c3JjL2FwaS90ZWxlbWV0cnkvVGVsZW1ldHJ5QVBJLmpz) | `90.11% <100.00%> (+0.90%)` | :arrow_up: | ... and [19 files with indirect coverage changes](https://app.codecov.io/gh/nasa/openmct/pull/7930/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/nasa/openmct/pull/7930?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/nasa/openmct/pull/7930?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa). Last update [ea9947c...6569c75](https://app.codecov.io/gh/nasa/openmct/pull/7930?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa).