[x] I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.
Describe the contribution
Use the "virtual_path" instead of "device_name" as the name record for FS_BASED entries. This should allow duplicate detection to work as expected.
The device_name on mappings made via this method will now be an empty string. It is not relevant because this type of map is used for devices that are already mounted.
Fixes #1433
Testing performed
Run all tests, validate OSAL behavior
Expected behavior changes
Using OS_FileSysAddFixedMap() with similar system paths should work as expected.
System(s) tested on
Debian
Additional context
Duplicate detection is now done on virtual path, not system path. Therefore it is (theoretically) possible to mount the same system path in more than one virtual location, but the same virtual location cannot be mapped to multiple system paths. This makes more sense than the inverse.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.
Checklist (Please check before submitting)
Describe the contribution Use the "virtual_path" instead of "device_name" as the name record for FS_BASED entries. This should allow duplicate detection to work as expected.
The device_name on mappings made via this method will now be an empty string. It is not relevant because this type of map is used for devices that are already mounted.
Fixes #1433
Testing performed Run all tests, validate OSAL behavior
Expected behavior changes Using
OS_FileSysAddFixedMap()
with similar system paths should work as expected.System(s) tested on Debian
Additional context Duplicate detection is now done on virtual path, not system path. Therefore it is (theoretically) possible to mount the same system path in more than one virtual location, but the same virtual location cannot be mapped to multiple system paths. This makes more sense than the inverse.
Contributor Info - All information REQUIRED for consideration of pull request Joseph Hickey, Vantage Systems, Inc.