Open samuel-krain opened 1 month ago
This appears to be a very easy fix by changing the final parameter to match the header file - might make a good first issue?
@dzbaker - is it possible to prioritize this one along w/ a CI review as to how this wasn't caught (and confirm there isn't a systematic issue)?
Describe the bug The file
.../portable/os-impl-no-select
has two functions,OS_SelectSingle_Impl()
andOS_SelectMultiple_Impl()
. These both have the final parameterint32 msecs
, which does not match the header definitions inos-shared-select.h
where the final parameter is insteadOS_time_t abs_timeout
.As a result, there is a compiler error when the file
os-impl-no-select
is compiled.Note: files are only compiled when using RTEMS OS with libnetworking library disabled.
To Reproduce Steps to reproduce the behavior:
Clone OSAL repo into empty directory
Add the rtems6 toolchain file from CFE Repo
Modify toolchain file:
CMAKE_SYSTEM_VERSION
to6
pc-rtems
BSPAdd the
RTEMS.cmake
platform module from the PSP repo in./Platform
Add the following lines before
project()
in top-level CMakeLists.txt:Expected behavior Compilation without errors.
Code snips os-impl-no-select.c:
os-shared-select.h:
Additional Context
OSAL does not appear to be compatible with libbsp library which replaces libnetworking in RTEMS6. Therefore, networking is more likely to be disabled.
System observed on:
Hardware:
OS: Ubuntu 22.04.4 LTS (kernel 6.5.0)
Versions: OSAL commit d6412df in main (latest as of 07-16-24)
Reporter Info Samuel Krain