Function in Composite Model

nasa / progpy

The NASA Prognostic Python Packages is a Python framework focused on defining and building models and algorit for prognostics (computation of remaining useful life) of engineering systems, and provides a set of models and algorithms for select components developed within this framework, suitable for use in prognostic applications.

https://nasa.github.io/progpy/

Other

52 stars 7 forks source link

Function in Composite Model #124

Closed teubert closed 9 months ago

teubert commented 9 months ago

Updated composite model to allow generic functions of one or more argument f(...)->float to be used for simple transformations between models.

Function inputs are the argument names. Outputs is 'function.return'.

Also added tests, updated the description, and added to the combining models example notebook.

Also a few changes cleaning up the code (applying linter suggestions) in composite model

github-actions[bot] commented 9 months ago

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

[ ] Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
[ ] Ensure that each PR adding a new feature should include a test verifying that feature.
[ ] All errors from static analysis must be resolved.
[ ] Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
[ ] Review the software benchmarking results (if there is a change) - will be added as comment on PR
[ ] Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
[ ] All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3dfe48b) 83.15% compared to head (258e9f7) 83.37%. Report is 1 commits behind head on dev.

Files	Patch %	Lines
src/progpy/composite_model.py	88.23%	6 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #124 +/- ## ========================================== + Coverage 83.15% 83.37% +0.21% ========================================== Files 100 100 Lines 10316 10427 +111 ========================================== + Hits 8578 8693 +115 + Misses 1738 1734 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.