Closed teubert closed 1 year ago
Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:
Merging #75 (72716fd) into dev (81d8448) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## dev #75 +/- ##
=======================================
Coverage 84.25% 84.26%
=======================================
Files 99 99
Lines 10164 10167 +3
=======================================
+ Hits 8564 8567 +3
Misses 1600 1600
Files Changed | Coverage Δ | |
---|---|---|
src/progpy/predictors/monte_carlo.py | 91.91% <100.00%> (+0.25%) |
:arrow_up: |
Ports over a few bugfix to the Monte Carlo. Fixes issue where horizon is not applied correctly.
Also changed the example to use MultivariateNormal Distribution and added associated tests.
Thank you @kjjarvis for your work on this.