Port over changes from prog_algs hotfix v1.5.1

nasa / progpy

The NASA Prognostic Python Packages is a Python framework focused on defining and building models and algorit for prognostics (computation of remaining useful life) of engineering systems, and provides a set of models and algorithms for select components developed within this framework, suitable for use in prognostic applications.

https://nasa.github.io/progpy/

Other

55 stars 8 forks source link

Port over changes from prog_algs hotfix v1.5.1 #75

Closed teubert closed 1 year ago

teubert commented 1 year ago

Ports over a few bugfix to the Monte Carlo. Fixes issue where horizon is not applied correctly.

Also changed the example to use MultivariateNormal Distribution and added associated tests.

Thank you @kjjarvis for your work on this.

github-actions[bot] commented 1 year ago

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

[ ] Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
[ ] Ensure that each PR adding a new feature should include a test verifying that feature.
[ ] All errors from static analysis must be resolved.
[ ] Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
[ ] Review the software benchmarking results (if there is a change) - will be added as comment on PR
[ ] Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
[ ] All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

codecov-commenter commented 1 year ago

Codecov Report

Merging #75 (72716fd) into dev (81d8448) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev      #75   +/-   ##
=======================================
  Coverage   84.25%   84.26%           
=======================================
  Files          99       99           
  Lines       10164    10167    +3     
=======================================
+ Hits         8564     8567    +3     
  Misses       1600     1600

Files Changed	Coverage Δ
src/progpy/predictors/monte_carlo.py	`91.91% <100.00%> (+0.25%)`	:arrow_up: