Overrun warning false alarm for CFE_MSG_Message_t

nasa / sample_app

The Core Flight System (cFS) Sample App (sample_app)

Apache License 2.0

50 stars 43 forks source link

Overrun warning false alarm for CFE_MSG_Message_t #158

Open ArielSAdamsNASA opened 3 years ago

ArielSAdamsNASA commented 3 years ago

Describe the bug Overrunning struct type CFE_MSG_Message_t of 16 bytes by passing it to a function which accesses it at byte offset 19 using argument 20UL.

Expected behavior Fix overrun

Code snips https://github.com/nasa/sample_app/blob/d009197df721af1f430d173584fa64a507a94a13/fsw/src/sample_app.c#L166-L167

System observed on: Coverity: https://scan.coverity.com/projects/arielsadamsnasa-cfs-jsf-rules?tab=overview

Reporter Info Ariel Adams, ASRC Federal

skliper commented 3 years ago

Not a real overrun since there is sufficient memory allocated. Should still clean up to squash warning, switching to enhancement. Related to nasa/cFE#1992.