search

nasa / stitchee

Harmony service that concatenates netCDF4 data files along an existing dimension
https://stitchee.readthedocs.io/
Apache License 2.0
6 stars 0 forks source link

improve test coverage for dimension cleanup #248

Closed danielfromearth closed 1 week ago

danielfromearth commented 2 weeks ago

GitHub Issue: #237

Description

Improved test coverage, though dimension cleanup still has the main duplicate dimension function not covered. It needs further work, or to be removed following the implementation of using DataTree (as in issue https://github.com/nasa/stitchee/issues/138).

PR Acceptance Checklist

📚 Documentation preview 📚: https://stitchee--248.org.readthedocs.build/en/248/

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/1.6.0@2e38bb3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
concatenator/dimension_cleanup.py 25.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/1.6.0 #248 +/- ## ================================================ Coverage ? 88.11% ================================================ Files ? 11 Lines ? 648 Branches ? 0 ================================================ Hits ? 571 Misses ? 77 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/nasa/stitchee/pull/248/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/nasa/stitchee/pull/248/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa) | `44.90% <0.00%> (?)` | | | [unittests](https://app.codecov.io/gh/nasa/stitchee/pull/248/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa) | `85.64% <25.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: