search

nate-strauser / meteor-uploadcare-plus

3 stars 3 forks source link

Improvements #4

Closed rafa-munoz closed 8 years ago

rafa-munoz commented 8 years ago

This PR brings many improvements:

  1. Updates to the last 2.9.0 version
  2. Adds tests to check almost everything
  3. Gives the possibility to add more settings to the widget
  4. Changes slightly the interface

Regarding changing the interface, it's a necessary change in order to have tests in the application. Anyway it doesn't break compatibility, it just marks the old method as deprecated in the console.

rafa-munoz commented 8 years ago

@nate-strauser Looking for your comments :)

nate-strauser commented 8 years ago

overall i think this looks really good - but i'd like to change the namespace

let's make it be UploadCarePlus.load() - that seems better to me than UCPlus.loadUploadcare()

thanks!

rafa-munoz commented 8 years ago

@nate-strauser I already did the changes. I agree to what you say, it's much better :)

nate-strauser commented 8 years ago

package is published - thanks again!