search

natesales / pathvector

Declarative routing platform that automates BGP route optimization and control plane configuration with secure and repeatable routing policy.
https://pathvector.io
MIT License
206 stars 26 forks source link

Invalidation of bgpq-args on auto-detected AS-SET. #192

Open CloudieLLC opened 11 months ago

CloudieLLC commented 11 months ago

Describe the bug Saw this on a couple of ASNs when I was doing a generate, despite having bgpq-args: set, if a user has a prefixed AS-SET from peeringdb, it will ignore everything except the source provided by PeeringDB. (and doubling up on the command.)

Environment ALL

To Reproduce User have prefixed AS-SET on PeeringDB, while bgpq-args is set.

Expected behavior Use bgpq-args wherever possible, and if not present, utilize prefixed as found on PDB.

Eg; (sorry Kyle, legit the first ASN I saw, and just changed it) ..

bgpq-args: -S RPKI,AFRINIC,ARIN,APNIC,LACNIC,RADB,RIPE (or any variation of it) PeeringDB: RIPE::AS-SERVERFORGE

Spawns as bgpq4 -S RPKI,AFRINIC,ARIN,APNIC,LACNIC,RADB,RIPE -h rr.ntt.net -Ab4 -S RIPE AS-SERVERFORGE which outputs NULL in this case;

Reason for wanting bgpq-args as primary if set.. well... people can.. be not smart sometimes :)

natesales commented 11 months ago

Modern bgpq4 interprets the SOURCE:: syntax natively now, so the old -S override can go away entirely.

https://github.com/bgp/bgpq4#notes-on-sources