search

nathanboktae / mocha-phantomjs

:coffee: :ghost: Run client-side mocha tests in the command line through phantomjs
MIT License
954 stars 112 forks source link

Update PhantomJS dependency to allow newer versions #212

Closed mroderick closed 9 years ago

mroderick commented 9 years ago

This will help projects using mocha-phantomjs and other PhantomJS dependent tools to only have to download one version of PhantomJS per checkout. This will save valuable resources for both bitbucket and users.

nathanboktae commented 9 years ago

Please seach issues and read the readme before submitting PRs, thanks. #167

nathanboktae commented 9 years ago

If the download bugs you, use mocha-phantomjs-core yourself directly.

mroderick commented 9 years ago

I'll take a look at that, thanks.

Perhaps adding a CONTRIBUTING.md would save future contributors from creating unwanted pull requests: https://github.com/blog/1184-contributing-guidelines