search

nathanboktae / mocha-phantomjs

:coffee: :ghost: Run client-side mocha tests in the command line through phantomjs
MIT License
954 stars 112 forks source link

Switch to phantomjs-prebuilt@2.1.3 #224

Closed papandreou closed 8 years ago

papandreou commented 8 years ago

Thus upgrading to Phantom.JS 2.1.1

@nathanboktae, I saw your comment on #175, and I agree that bring-your-own-binary would be even better in the long run.

nathanboktae commented 8 years ago

I think all the failed tests speak loud enough but

I agree that bring-your-own-binary would be even better in the long run.

I'm very sold on this. Between the drama from Medium's phantomjs to the phantomjs to now this phantomjs-prebuilt, #167 (#199), along with code bases that aren't ready to go to phantomjs2 and I am about to support SlimerJS on mocha-phantomjs-core, I had not yet made an official announcement, but I will be deprecating this project in favor of the BYOB version - after I move the command line parsing stuff into the core. There's too much hurt in trying to force users on the same binary, and force them in a certain way to get a binary. Most Hosted CI ssytems have it pre-instanalled, if not adding a wget | tar command is really trivial.