Closed etiennebacher closed 1 year ago
Merging #113 (d3f0898) into master (bbb9aed) will increase coverage by
0.05%
. The diff coverage is96.29%
.
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 93.53% 93.58% +0.05%
==========================================
Files 58 59 +1
Lines 1455 1482 +27
==========================================
+ Hits 1361 1387 +26
- Misses 94 95 +1
Impacted Files | Coverage Δ | |
---|---|---|
R/fill.R | 96.29% <96.29%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I have today returned from holiday. I will try and look at this this evening. Thanks for the hard work.
No problem, take your time (to be honest I forgot this PR)
Small bump (I'm going through my open PRs to see if they can be merged/closed)
No problem ;)
Reproduce
tidyr::fill()
. I took the main part of the function (the filling algorithm) in a SO answer and I must say I'm not super confident of how it works, but it works and it's fast.A few tests are missing, for lists for example (see tidyr tests. There's also a weird message with groups (see last example).
Examples:
Created on 2022-08-26 by the reprex package (v2.0.1)