nathaneastwood / poorman

A poor man's dependency free grammar of data manipulation
https://nathaneastwood.github.io/poorman/
Other
338 stars 15 forks source link

Grouped Data Frames Share a Class Name with Their Dplyr Equivalent #70

Closed alex-gable closed 3 years ago

alex-gable commented 3 years ago

Describe the solution you'd like Ideally, if poorman is desired to be swappable with dplyr, it would use the same class name for grouped data frames, in order that S3 methods looking for grouped_df don't need to be swapped to grouped_data. Probably seems like a small thing, but being unfamiliar with S3 classes, it took me a while to figure out why tests were failing for a grouped case and how to fix it.

Suggest code changes I imagine it'd be a find and replace for grouped_data to grouped_df

Additional context Example change here.